Open
Conversation
Contributor
derbynn
commented
Oct 2, 2024
derbynn
commented
- Write up the recent example in transforming a sheet and all of its content to a target iModel
nick4598
reviewed
Oct 3, 2024
sheet-transformation.md
Outdated
| throw new Error("A sheet must be named."); | ||
| } | ||
|
|
||
| // create a blank sheetModelId(where we will insert the sheet data), create documentListModel (where we will insert list of document elements) |
Contributor
There was a problem hiding this comment.
maybe hyperlink to https://www.itwinjs.org/reference/core-backend/models/documentlistmodel/?
https://www.itwinjs.org/reference/core-backend/elements/sheet/
https://www.itwinjs.org/reference/core-backend/models/sheetmodel/
Mention that a sheet is a document element
sheet-transformation.md
Outdated
| }); | ||
|
|
||
| const importer = new IModelImporter(iModel); | ||
| importer.doNotUpdateElementIds.add(documentListModelId); // Do not update the documentListModelId, this is the one we've created for this iModel to receive the sheet template. |
Contributor
There was a problem hiding this comment.
Suggested change
| importer.doNotUpdateElementIds.add(documentListModelId); // Do not update the documentListModelId, this is the one we've created for this iModel to receive the sheet template. | |
| importer.doNotUpdateElementIds.add(documentListModelId); // Do not update the documentListModelId, this is the one we've created for this iModel to receive the sheet template. We do this in order to keep the properties of the documentListModel that we set in `createSheetInternal`. Without this line the documentListModel's properties in the source iModel overwrite the target iModel's documentListModel. |
Contributor
There was a problem hiding this comment.
Can you format this? It might need to be on two lines if its too long
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
Co-authored-by: Nick Tessier <22119573+nick4598@users.noreply.github.com>
…/iTwin/imodel-transformer into daniel/transformer-sheets-sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.