[WIP] iTwin.js v5 by aruniverse · Pull Request #234 · iTwin/imodel-transformer

aruniverse · 2025-02-10T17:23:06Z

No description provided.

iTwin/itwinjs-core#7512 makes the internal APIs `IModelDb.nativeDb` and `IModelHost.platform` inaccessible outside of the core-backend package. --------- Co-authored-by: nick.tessier <22119573+nick4598@users.noreply.github.com> Co-authored-by: Daniel Rodriguez <DanRod1999@users.noreply.github.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: Arun George <aruniverse@users.noreply.github.com>

anmolshres98 · 2025-06-17T15:06:53Z

We can probably publish and try and merge this PR @aruniverse

aruniverse · 2025-06-17T15:43:52Z

We can probably publish and try and merge this PR @aruniverse

You can publish a new pre release but let's hold off on the 2.0 for now. I want to review this PKG a bit more

DanRod1999 · 2025-07-29T14:56:49Z

packages/transformer/src/test/IModelTransformerUtils.ts

  }
+  private accountForPartialViewDefinition2d(elementProps: ElementProps): void {
+    const view2d = elementProps as unknown as ViewDefinition2d;
+    // if the ViewDefinition2d has a baseModelId, it should be a valid Id64String otherwise insert/get operations will fail.


@khanaffan @MichaelSwigerAtBentley, would appreciate reviewing this func, as the issue started after some of you're guys work in native. I think Mike worked with Anmol a bit on this, but wanted a quick review to make sure this logic seems sound. Lgtm, but want to make sure temporarily setting this baseModelId wouldn't have unanticipated consequences before the correct value is reconciled. Thanks!

So its just assigning a placeholder 0x1 as the baseModelId in cases where it is defined but not a valid Id64?

packages/performance-scripts/package.json

DanRod1999 · 2026-02-11T20:46:49Z

All usages of withPreparedStatement() have been replaced except for 2 instances. First occurrence is mentioned above. Second, is in the ElementCascadingDeleteCode. I believe I cannot update this because it is part of an override for processElementTree() which is in itjs core and currently sync. I don't think I can change the current code here unless the method in itjs is changed.

aruniverse · 2026-02-11T21:10:01Z

@itwin/transformation-service can you guys please help in reviewing the changes here?

packages/test-app/src/test/Transformer.test.ts

packages/transformer/src/test/TestUtils/IModelTestUtils.ts

packages/transformer/src/test/standalone/IModelCloneContext.test.ts

packages/transformer/src/test/standalone/IModelTransformer.test.ts

packages/transformer/src/IModelTransformer.ts

into itwinjs-v5

packages/transformer/src/EntityUnifier.ts

into itwinjs-v5

aruniverse and others added 14 commits February 10, 2025 12:22

update ci

a55c0ed

Merge branch 'main' into itwinjs-v5

6ebbb4a

Merge branch 'main' into itwinjs-v5

b831fd1

WIP- updating to 5.x

3d70107

passing build

0fcca08

remove cmnt

646cf6d

extract row as object

70ec6d8

update latest itjs rc + other deps

0e2c80c

disableThinnedNativeInstanceWorkflow = true

902cd87

format

867b607

replace hubAccess.queryChangeset() with Briefcase manager

73017a9

Version bump [skip actions]

b077dbb

latest rc

cde2d17

anmolshres98 force-pushed the itwinjs-v5 branch from 03bb7c7 to cde2d17 Compare May 27, 2025 19:58

anmolshres98 and others added 7 commits May 27, 2025 15:26

2.0.0-dev.0

7f780d7

Version bump [skip actions]

45d5bd1

swap IModelHost[_hubAccess] with BriefcaseManager

b292c28

Version bump [skip actions]

1ef96d0

rc - 5.0.0-dev.116

bc67e9a

fix so not throwing in 5.x itjs core-backend

c5accff

Version bump [skip actions]

640d9e4

anmolshres98 linked an issue Jun 4, 2025 that may be closed by this pull request

ViewDefinition2d element is processed before its "baseModel" element is processed #262

Open

anmolshres98 and others added 2 commits June 16, 2025 17:05

itjs 5.0 official

7576435

Version bump [skip actions]

0813ad5

compile w/ latest 5.1

028d92f

DanRod1999 reviewed Jul 29, 2025

View reviewed changes

MichaelSwigerAtBentley reviewed Jul 31, 2025

View reviewed changes

packages/performance-scripts/package.json Outdated Show resolved Hide resolved

DanRod1999 added 7 commits February 9, 2026 10:33

EntityUnifier.exists() async

083d0e4

TimelineTestUtils.ts deprecations

d1d979e

ElementUtils.ts createQueryReader()

fe41021

Transformer.test.ts fix deprecated

4d9595d

test-app transformer.ts async

b9a5f95

missed 1 isntance of withPreparedStatement in findTargetEntityId

bd954b6

cleanup

36b4793

aruniverse requested a review from Copilot February 11, 2026 21:08

lint

371808a

This comment was marked as resolved.

Sign in to view

DanRod1999 and others added 2 commits February 11, 2026 16:51

stop using setDefaultView

3079717

Version bump [skip actions]

5874f7d

JulijaRamoskiene reviewed Feb 12, 2026

View reviewed changes

DanRod1999 and others added 10 commits February 16, 2026 10:03

test app usePrimaryConn

b199bba

usePrimaryConn: true

16dd4b5

Merge branch 'itwinjs-v5' of https://github.com/iTwin/imodel-transformer

5543519

into itwinjs-v5

wip review comments

5d13822

copilot comments

2e42ead

fix query, use schema context for exportSchemas

3beb981

update itjs version and fix clone element change

9eeeed6

cleanup and bump test app

72e1fd5

update perf pkgs

bdfbbec

Version bump [skip actions]

ada154d

DanRod1999 reviewed Feb 23, 2026

View reviewed changes

packages/transformer/src/EntityUnifier.ts Outdated Show resolved Hide resolved

DanRod1999 and others added 4 commits February 24, 2026 17:02

EntityUnifier.exists() perf regression

5334be1

skip perf

ce7fb39

Merge branch 'itwinjs-v5' of https://github.com/iTwin/imodel-transformer

21804c2

into itwinjs-v5

Version bump [skip actions]

17f34be

Conversation

aruniverse commented Feb 10, 2025

Uh oh!

anmolshres98 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aruniverse commented Jun 17, 2025

Uh oh!

DanRod1999 Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

MichaelSwigerAtBentley Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DanRod1999 commented Feb 11, 2026

Uh oh!

aruniverse commented Feb 11, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

anmolshres98 commented Jun 17, 2025 •

edited

Loading