Skip to content

Conversation

@pmconne
Copy link
Member

@pmconne pmconne commented Jul 28, 2025

Implements decoding and rendering of EXT_mesh_primitive_edge_visibility.
Fixes #8362.

@pmconne pmconne changed the title Ext mesh primitive visibility EXT_mesh_primitive_visibility Jul 28, 2025
@pmconne pmconne marked this pull request as ready for review July 30, 2025 13:32
@danielzhong-bentley
Copy link
Contributor

Still planning to implement the material property for EXT_mesh_primitive_edge_visibility ?

@pmconne
Copy link
Member Author

pmconne commented Jul 30, 2025

Still planning to implement the material property for EXT_mesh_primitive_edge_visibility ?

The only thing we would use that for is planar regions for which the outline color differs from the fill color. Today iMdl outputs those as separate polyline primitives entirely, with an isEdge=true flag for the renderer. Changing that looks complicated - I will see how it might be done before deciding whether it's worth doing now in our existing tiler, vs doing it properly in the consolidated tiler.

@pmconne pmconne changed the title EXT_mesh_primitive_visibility EXT_mesh_primitive_edge_visibility Jul 31, 2025
@pmconne pmconne requested a review from a team as a code owner August 1, 2025 00:22
@pmconne pmconne requested review from hl662 and wgoehrig August 1, 2025 00:22
@pmconne
Copy link
Member Author

pmconne commented Aug 1, 2025

Still planning to implement the material property for EXT_mesh_primitive_edge_visibility ?

I implemented the decoding+rendering side in this PR.

@pmconne
Copy link
Member Author

pmconne commented Aug 1, 2025

Awaiting ImageTests results. First build spent an hour pulling BisSchemas. Second claimed BisSchemas isn't a git repository.

@pmconne
Copy link
Member Author

pmconne commented Aug 1, 2025

No image differences.

@pmconne pmconne enabled auto-merge (squash) August 1, 2025 15:23
@pmconne pmconne disabled auto-merge August 1, 2025 15:57
@pmconne pmconne merged commit e59179d into master Aug 1, 2025
14 of 15 checks passed
@pmconne pmconne deleted the EXT_mesh_primitive_visibility branch August 1, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support glTF EXT_mesh_primitive_edge_visibility in iTwin.js

6 participants