Added custom portal property for ArcGIS map-layers, to support OAuth2 authentication.#8609
Merged
Conversation
mdastous-bentley
requested review from
a team,
aruniverse,
bbastings and
ben-polinsky
as code owners
aruniverse
reviewed
Oct 3, 2025
aruniverse
reviewed
Oct 3, 2025
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom portal URLs in ArcGIS map layers to improve OAuth2 authentication reliability. Previously, the portal URL was inferred from the map layer URL, which could lead to authentication failures.
- Added optional
portalproperty toMapLayerAccessTokenParamsinterface - Deprecated
mapLayerUrlproperty in favor of the newportalproperty - Updated ArcGIS imagery provider to use the custom portal URL when provided
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MapLayerAuthentication.ts | Added optional portal property and deprecated mapLayerUrl |
| ArcGISImageryProvider.ts | Updated to pass custom portal URL to authentication client |
| MichelD-maplayers_portal_2025-10-03-20-05.json | Added changelog entry for the feature |
| core-frontend.api.md | Updated API documentation to include new portal property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@aruniverse Ideally we would like get this backported to latest release branch as we need it in the short term. |
Member
|
@Mergifyio backport release/5.2.x |
Contributor
✅ Backports have been createdDetails
|
aruniverse
approved these changes
Oct 6, 2025
eringram
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously inferred portal URL from map-layer URL, which can potentially to lead to failures. Instead, if a ArcGIS enterprise server has a custom portal URL, end-user should should be able to supply it part of its map-layer definition, and the provider will pass the information to access client.
This will also align with the OAuth2 support offered by
@esri/arcgis-rest-request