-
Notifications
You must be signed in to change notification settings - Fork 241
Add the ability to release the locks associated with reversed Txns #9045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
32ade4f
First cut at a system for releasing locks that were acquired during a…
kring 5f3bf6d
Fix logic error in recursive lock checking.
kring 01aa71e
Add test for releaseLocksForReversedTxn.
kring 13e3f23
Add another lock release test.
kring f61c84f
Simplify invalidation of Discovered locks when releasing Txn locks.
kring 1cea987
Separate table to associate locks with Txns.
kring e9d2e92
Add test for reversing lock upgrades.
kring a639511
Add acquireLocksForReinstatedTxn (not tested yet).
kring 8e54f95
Add a basic test for acquireLocksForReinstatedTxn.
kring 5346686
Tweaks and tests.
kring 8e63c89
Add doc to LockControl interface.
kring 468ad70
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 5f694bc
Don't update changeset when abandoning locks.
kring b7fd37b
Lock abandonment.
kring 5d56e64
release -> abandon in appropriate places.
kring f26357e
LocalHub-friendly way of specifying "no changeset".
kring 8e00875
Better attempt at hub-friendly non-changeset.
kring c85bbc0
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring ab9046b
Preserve NewElement origin when abandoning/reacquiring locks.
kring 906aa77
Better terminology.
kring 1592cb0
Extend LocalHub with new methods.
kring b050f31
Fix typos.
kring 7b17bf0
Lint.
kring 43b15b3
rush change
kring 2568d41
Add check that releaseLocksForReversedTxn is used correctly.
kring ea3d5e7
Clarify order of releaseLocksForReversedTxn and acquireLocksForReinst…
kring 414cb0a
extract-api
kring 9d4ea34
Remove nonsense changes generated by extract-api?
kring 701da9c
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 1765436
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 9a9204d
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 09650c3
releaseAfterAbandon -> abandon
kring 95c27fa
Throw IModelError instead of Error when here are local changes.
kring 17e2b0a
More release -> abandon.
kring 7c1fbf6
A few more release -> abandon.
kring f4a00a8
Automatically release txn locks on reverse.
kring 1ed9935
WIP acquire locks on reinstate.
kring e7fffe5
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 6d026b7
Run extract-api.
kring fbf7d5b
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 60c8dd3
Merge remote-tracking branch 'origin/kring/release-txn-locks' into kr…
kring d82f0a0
Add new "AndAbandonLocks" methods.
kring 1cc6c01
Track txn lock abandonment.
kring d3d27e1
Improving TxnManager integration.
kring 2ccd4e1
Much better logic for clearing txn lock records.
kring ba2885a
Doc improvements.
kring dba045c
More predictable lock abandon / reacquire behavior.
kring 75bb497
Explicit distinction between current unsaved txn and committed ones.
kring acb8566
More tests.
kring 0e9d9e3
Another test.
kring a1b8111
Some last tests.
kring 55abee1
Run extract-api.
kring f4146f5
Lint
kring bd56842
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 4298484
Use ITwinError instead of IModelError for newly added exceptions.
kring 8aaa341
Better way of inserting into txn_locks.
kring 9b232f7
Improve consistency of exception.
kring b531df7
Don't cancel txns if lock abandonment fails.
kring 55942e3
Remove empty ServerBasedLocksError interface.
kring bfd04da
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 7267b92
Rename new TxnManager methods to *Async.
kring e493ae4
Add args to async reverse and reinstate methods.
kring 0ae1f4e
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 21ecae0
Improvements to lock abandonment.
kring 9c75fa6
extract-api
kring 787be4b
@bentley/imodeljs-native 5.8.14
imodeljs-admin 1de3034
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 078996d
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring de8fb1f
Fix doc errors.
kring 9cc4695
Don't try to link to internal type in doc.
kring 3f6cd09
Avoid duplicate (txnId,elementId) rows in the txn_locks table.
kring 9aaf813
Save changes after clearTxnLockRecords.
kring 565e3e0
Fix incorrect error message.
kring f2ef5f2
Fix doc typo.
kring e8030ae
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 3a342c0
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 967674e
rush update
kring 29c0379
Merge branch 'master' into kring/release-txn-locks
DanRod1999 fa0d4ef
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 046e61d
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 4a75062
Merge branch 'master' into kring/release-txn-locks
ben-polinsky a83a1d8
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring feeeecc
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring f108220
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 43aa055
Merge branch 'master' into kring/release-txn-locks
kring 0cbd044
Merge branch 'master' into kring/release-txn-locks
kring b36db68
Merge branch 'master' into kring/release-txn-locks
kring 771239d
Merge branch 'master' into kring/release-txn-locks
kring 270a118
Merge branch 'master' into kring/release-txn-locks
kring d6188b0
Remove TODO.
kring 4fb8d73
Clarify BackendHubAccess docs.
kring d83f876
Fix typo.
kring 5f0b731
Add change description.
kring 6fe7a42
Clarify comments.
kring 6e2b722
Fix typo.
kring e6df7f5
Don't mention internal type in doc.
kring 53837f1
Make new TxnManager APIs beta.
kring 25f7f84
Mark new methods in LockControl and BackendHubAccess beta.
kring 8b47b1a
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring b1b1709
Merge branch 'master' into kring/release-txn-locks
kring 03d0c59
Merge branch 'master' into kring/release-txn-locks
kring 3cebdeb
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 93c467b
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 66f5126
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring d370efa
Bring lock abandonment to the frontend.
kring f8d5162
Merge remote-tracking branch 'origin/master' into kring/release-txn-l…
kring 6dce957
Run extract-api.
kring 50c2422
Lint.
kring bcb6e6a
Add frontend changes file.
kring 14cffb3
Update new tests for EditTxn.
kring 07f1cbf
Merge branch 'master' into kring/release-txn-locks
kring 4a6413a
Merge branch 'master' into kring/release-txn-locks
kring f73ed10
Merge branch 'master' into kring/release-txn-locks
kring c2a3478
Merge branch 'master' into kring/release-txn-locks
kring e76d7ba
Merge branch 'master' into kring/release-txn-locks
kring 94c6525
Use BriefcaseDb.findByKey instead of IModelDb.findByKey.
kring File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-backend/kring-release-txn-locks_2026-03-02-06-31.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-backend", | ||
| "comment": "Added the ability to release locks associated with reversed Txns.", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-backend" | ||
| } |
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-common/kring-release-txn-locks_2026-03-16-13-12.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-common", | ||
| "comment": "Added async versions of Txn reverse and reinstate operations, and added support for abandoning locks when reversing Txns.", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-common" | ||
| } |
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-frontend/kring-release-txn-locks_2026-04-09-23-59.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-frontend", | ||
| "comment": "Added async versions of Txn reverse and reinstate operations, and added support for abandoning locks when reversing Txns.", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-frontend" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,4 +128,4 @@ | |
| "nyc": { | ||
| "extends": "./node_modules/@itwin/build-tools/.nycrc" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.