Add SolidPrimitive.isSkew and Cone.cylinderRadius#9279
Merged
Conversation
…Curve.test.ts, and helper function to top of Solid.test.ts.
…Curve.test.ts, and helper function to top of Solid.test.ts.
…n/itwinjs-core into da4/solid-primitive-is-skew
saeeedtorabi
approved these changes
May 11, 2026
bbastings
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These helper methods should be helpful for iTwin editing logic that decides which edit handles to display on a
SolidPrimitive:SolidPrimitive.isSkewnominally returns whether the solid's local z-axis is not perpendicular to its local xy-plane.Cone.cylinderRadiusis a test for whether a Cone is a cylinder (circular cross sections of equal radius and no skew). The caller can optionally request a weaker test that allows skew.