Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially built and tested this in a node enviroment for redirect. We did not support browser environments.
Redirect handling in Node vs browser
In Node (node-fetch),
redirect: "manual"still exposes status and headers, so we can readLocationand enforce our redirect policy. In browsers, the same setting yieldsopaqueredirect, which hides status/headers/body, so we can’t evaluate the redirect.Using base fetch with default
followdoes not let us enforce our security measures before the redirect happens (Bentley-only domains, HTTPS-only, hop limits). In Node we can still do that with manual redirects; in browsers we can only validate the final URL after follow completes.Solution
Now we have support for both while mataining more robust security in the node enviroment that we can not get with base fetch in browser enviroment.
Added playwrite tests to confrom browser enviroment is working.
#77