Fix flaky context menu item test by correcting waitFor() usage and adding PropertyGrid load wait#1533
Fix flaky context menu item test by correcting waitFor() usage and adding PropertyGrid load wait#1533MattHandzel wants to merge 1 commit intoiTwin:masterfrom
Conversation
grigasp
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good.
|
@MattHandzel thanks - could you run
|
…ding PropertyGrid load wait Fixes iTwin#1516
Hello @ben-polinsky, I ran prettier, not sure if you get notified when I make a commit or if I should write you with a comment like this, but it should be ready to be merged :) |
Thanks. I didn't get notified until you commented. Re-ran the pipelines and prettier is still complaining: |
The "renders context menu item" test was flaky due to two root causes:
Incorrect waitFor() usage: The test had an async callback that executed user.pointer() and immediately checked the assertion without waiting for the DOM to update. The waitFor() callback should be synchronous.
Missing PropertyGrid load wait: The test attempted to interact with the PropertyGrid before it finished loading, causing the "Test SpatialCategory" element to not be found.
Changes:
Verification: