Improve RocksDB interface #23
Conversation
jurmous
commented
Oct 22, 2019
•
jurmous
commented
- Add keyMayExist methods
- Add file deletion methods
- Add background work pause and continue methods
- Fix spelling mistakes
jurmous
force-pushed
the
Improve-RocksDB-interface
branch
from
f1dd03e to
3889886
Compare
- Add keyMayExist methods - Add file deletion methods - Add background work pause and continue methods - Fix spelling mistakes
jurmous
force-pushed
the
Improve-RocksDB-interface
branch
from
3889886 to
7a74815
Compare
|
Hey @jurmous, I'll take a look at this tomorrow evening and will release a new version after the pull. I left a small feedback there in regards to the API, let's discuss it tomorrow in more detail. |
|
I don't see the feedback? Where can it be found? Probably I would like to expand this PR to add more methods to the RocksDB interface. Could also be a separate PR. Maybe it is good to wait a bit for a release so more methods can be added. I am still playing around to use this library as the iOS/Mac interface into a RocksDB Kotlin multiplatform module. Thanks for merging the others! And all the work in creating this library! 😄 |
Sorry my bad, I totally forgot about the new way GitHub starts reviews. I forgot to submit it. |
| */ | ||
| - (BOOL)keyMayExist:(NSData *)aKey | ||
| readOptions:(nullable void (^)(RocksDBReadOptions *readOptions))readOptions | ||
| value:(NSString * _Nullable *_Nullable)value; |
There was a problem hiding this comment.
I'm not really sure about the pass-by-ref parameter here. This breaks the trailing closure syntax and wouldn't translate nicely when used in Swift. Instead of returning BOOL how about returning a nullable NSString *.
|
If you want to expand upon this PR or open a new one, it would be much appreciated 😉 |
