fix: updated frontend Dockerfile to skip Cypress binary download - #20
Open
kettest96 wants to merge 1 commit into
Open
fix: updated frontend Dockerfile to skip Cypress binary download#20kettest96 wants to merge 1 commit into
kettest96 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the frontend Dockerfile to ensure smooth local development and container builds.
Changes Made
Updated Dockerfile to include ENV CYPRESS_INSTALL_BINARY=0
Prevents unnecessary Cypress binary download during npm install.
Reduces build time and avoids potential build failures inside Docker.
Verified frontend runs correctly on http://localhost:5173 after build.
Cleaned up dependencies (node_modules / package-lock.json) before install for consistency.
✅ Why This Fix Is Important
Original Dockerfile caused build warnings/errors due to Cypress attempting to install a large binary (not required for runtime).
Developers running locally or using Docker images no longer face failed builds.
This keeps the repo more beginner-friendly and reduces onboarding friction.