fix: correct week calculation when date is before year start week #2988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamkun#2987) When subtracting one week from January 4, 2026, the week number was incorrectly calculated as week 1 of 2025 instead of the correct week (52 or 53 depending on locale). The issue was in the recursive call when diffInWeek < 0. This fix replaces the recursive call with proper calculation based on the previous year's year start. - Fix week calculation for dates before year start week - Add test cases for issue iamkun#2987
Author
|
requesting your reviews @iamkun |
|
@SmartDever02 @iamkun I modified and submitted a PR based on my understanding; you can take a look. #2990 |
Author
|
are you open to contribution or not? please let me know @iamkun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2987
When subtracting one week from January 4, 2026, the week number was incorrectly calculated as week 1 of 2025 instead of the correct week (52 or 53 depending on locale).
The issue was in the recursive call when diffInWeek < 0. This fix replaces the recursive call with proper calculation based on the previous year's year start.
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=102175066