Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make defaultCountry prop reactive #499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vmisiko
Copy link

@vmisiko vmisiko commented Jan 22, 2025

VUE 3 FIx
-Make defaultCountry prop reactive - to update dynamically when default currency prop changes

@vmisiko vmisiko changed the title Fix: Make defaultCountry prop reactive - to update dynamically when defaultCurrency prop changes Fix: Make defaultCountry prop reactive Jan 22, 2025
Copy link

@MorningPants MorningPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! This does exactly what I need it to do.

@MorningPants
Copy link

On further testing, I am seeing that if there is an initial default country, it sets that up before quickly switching to USA. Can you reproduce this bug?

@MorningPants
Copy link

Ah, nevermind, that was just the auto default country hopping in. Turning that off fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants