Skip to content

Fix for reverse typing bug (Issue #31) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
archieherbias wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for reverse typing bug (Issue #31) #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb908d
Fix visible count to -1 when it goes down less than -1
archieherbias Oct 11, 2018
837670f
Fixed revesing typing value while on transition results to out of bou…
archieherbias Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/TypeWriter.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ class TypeWriter extends React.Component {
const active = this.props.typing;

if (active > 0 && next < 0) {
clearInterval(this._timeoutId);

@archieherbias archieherbias Oct 11, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition block here causes setting of visibleChars state to fire twice along with the _handleTimeout handler. So, clearing _handleTimeout is necessary.

this.setState({
visibleChars: this.state.visibleChars - 1
});
} else if (active <= 0 && next > 0) {
clearInterval(this._timeoutId);
this.setState({
visibleChars: this.state.visibleChars + 1
});
Expand Down Expand Up @@ -103,7 +105,7 @@ class TypeWriter extends React.Component {
} = this.state;
const container = <span {...props}>{children}</span>;
const hideStyle = fixed ? {visibility: 'hidden'} : {display: 'none'};

return styleComponentSubstring(container, hideStyle, visibleChars);
}

Expand Down