Merged
Conversation
Refactor the API for `CustomLexer` to add a `CustomLexerContext`. The context wraps the `context.Context` during lexing, and provides methods for accessing the input stream. Signed-off-by: Ian Lewis <ian@ianlewis.org>
There was a problem hiding this comment.
Pull request overview
This PR refactors the CustomLexer API by introducing a new CustomLexerContext type that wraps context.Context and provides access to lexer methods. The refactoring moves lexer interaction methods from CustomLexer to CustomLexerContext, changing the signature of LexState.Run to accept the new context type instead of both context.Context and *CustomLexer.
Changes:
- Introduced
CustomLexerContexttype that embedscontext.Contextand provides methods for lexer interaction - Updated
LexState.Runsignature to accept*CustomLexerContextinstead ofcontext.Contextand*CustomLexer - Moved public lexer methods (Peek, Advance, Emit, etc.) to
CustomLexerContextwhile keeping implementation inCustomLexeras private methods - Updated all lexer state functions and tests to use the new API
- Updated tests to use
t.Context()instead of manually creating contexts with cancel functions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| custom.go | Added CustomLexerContext type with public methods delegating to private CustomLexer methods; updated LexState interface |
| custom_test.go | Updated all test functions to use CustomLexerContext instead of direct CustomLexer access; renamed tests to reflect context usage |
| template_example_test.go | Updated lexer state functions to accept *CustomLexerContext parameter |
| ini_example_test.go | Updated lexer state functions to accept *CustomLexerContext parameter |
| lexparse_test.go | Updated test contexts to use t.Context() and updated lexErrState.Run signature |
| CHANGELOG.md | Added entry documenting the API refactoring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactor the API for
CustomLexerto add aCustomLexerContext. The context wraps thecontext.Contextduring lexing, and provides methods for accessing the input stream.Related Issues:
Updates #173
Checklist:
CONTRIBUTING.mddocumentation.CHANGELOG.mdif applicable.