feat: update CustomLexerContext to CustomLexerCursor#195
Merged
Conversation
fc9b09e to
9e768b1
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the CustomLexer state-machine API by renaming CustomLexerContext to CustomLexerCursor and passing context.Context separately, improving ergonomics for testing lexer state functions (per #188).
Changes:
- Rename
CustomLexerContext→CustomLexerCursorand updateLexState.Run/LexStateFnto accept(context.Context, *CustomLexerCursor). - Add
NewCustomLexerCursor(*CustomLexer)helper and updateCustomLexer.NextTokento use it. - Update README and example/tests to the new cursor-based API.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| custom.go | Introduces CustomLexerCursor, updates LexState API and NextToken to pass context.Context separately. |
| custom_test.go | Updates unit tests to use CustomLexerCursor and the new state signature. |
| lexparse_test.go | Updates a lexer test state to match new LexState.Run signature and imports context. |
| template_example_test.go | Updates template lexer example states to accept (context.Context, *CustomLexerCursor). |
| ini_example_test.go | Updates INI lexer example states to accept (context.Context, *CustomLexerCursor). |
| README.md | Updates public documentation/examples for the renamed cursor and new Run signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ian Lewis <ian@ianlewis.org>
9e768b1 to
24ed9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rename
CustomLexerContexttoCustomLexerCursorand separate it from thecontext.Context.Add a
NewCustomLexerCursorfunction to make it easier to create a cursor for testing lexer functions.Related Issues:
Checklist:
CONTRIBUTING.mddocumentation.CHANGELOG.mdif applicable.