Skip to content

fix: add try/finally block in withoutSaving method to ensure state re… #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

ederzz
Copy link
Contributor

@ederzz ederzz commented Apr 3, 2025

…storation

Description
When i perform some operations and put them in the history stack, then perform some other operations without putting them into the history stack, and then trigger an undo action, this action might fail - for example, it can not find the previous element.The error can cause the restoration of the SAVING state to fail, which in turn leads to the failure of subsequent historyEditor operations to record history.

Issue
Fixes: (link to issue)

Example
image

Context
I think we should catch the error from the callback of withoutSaving, make it won't affect the restoration of the saving state.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: 0568634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please add a changeset as it's a small change in behavior.

@ederzz ederzz force-pushed the fix/history-editor-state-restore branch from 0568634 to 8e7757f Compare April 4, 2025 10:38
@ederzz
Copy link
Contributor Author

ederzz commented Apr 4, 2025

Thanks for the PR, please add a changeset as it's a small change in behavior.

Fine, got it done!

@ederzz ederzz requested a review from dylans April 6, 2025 23:54
@dylans dylans merged commit 701d5f3 into ianstormtaylor:main Apr 15, 2025
7 of 11 checks passed
dylans pushed a commit to dylans/slate that referenced this pull request Apr 15, 2025
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants