fix: add try/finally block in withoutSaving method to ensure state re… #5837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…storation
Description
When i perform some operations and put them in the history stack, then perform some other operations without putting them into the history stack, and then trigger an undo action, this action might fail - for example, it can not find the previous element.The error can cause the restoration of the
SAVING
state to fail, which in turn leads to the failure of subsequent historyEditor operations to record history.Issue
Fixes: (link to issue)
Example

Context
I think we should catch the error from the callback of
withoutSaving
, make it won't affect the restoration of the saving state.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)