FIX: Unexpected auto-scrolling behavior when refocus the editor (issue: 5826) - #5882
Open
renasami wants to merge 4 commits into
Open
FIX: Unexpected auto-scrolling behavior when refocus the editor (issue: 5826)#5882renasami wants to merge 4 commits into
renasami wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: cf6b5ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I don’t think this is a safe fix. Calling That is a significant behavioral regression: clicking outside the editor, focusing toolbar inputs, dialogs, forms, or any other focusable control should be allowed to move focus away from the editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the editor would scroll to the previous focus position when rendering long text.
Issue
Fixes: 5826
Example
Current behaviors
2025-05-25.2.06.23.mov
Fixed behaviors
2025-05-25.2.01.34.mov
Context
It was missing scroll logic to the new caret position.
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)