fix: prevent Android IME first character duplication on empty nodes#6020
Open
joyboyguo-sketch wants to merge 1 commit into
Open
Conversation
When the cursor is positioned at an empty text node, Android IME treats the transition from empty to non-empty as a structural change and restarts composition, causing the first character to be duplicated. Fix by inserting a zero-width space (U+200B) at the start of composition when the current text node is empty. This makes the node appear non-empty to the IME, preventing the composition restart. The placeholder is automatically cleaned up from the AST after compositionEnd, keeping the document state clean. Fixes: Android IME first character duplication issue
|
|
good！it works for me！ |
Contributor
|
This fixes the issue for me on Gboard, but it's still present on Samsung Keyboard 3.3.23.33. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced with #5983
When the cursor is positioned at an empty text node, Android IME treats the transition from empty to non-empty as a structural change and restarts composition, causing the first character to be duplicated.
Fix by inserting a zero-width space (U+200B) at the start of composition when the current text node is empty. This makes the node appear non-empty to the IME, preventing the composition restart. The placeholder is automatically cleaned up from the AST after compositionEnd, keeping the document state clean.
Fixes: Android IME first character duplication issue
Issue
Fixes: (link to issue)
#5983