Handle numbers and booleans in slate-hyperscript - #6102
Open
12joan wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: e474d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
12joan
commented
Aug 31, 2026
| return !!match | ||
| }, | ||
|
|
12joan
commented
Aug 31, 2026
| name: 'Autocorrect', | ||
| instructions: | ||
| 'Type "Cant", then press space to autocorrect it. Make sure the cursor position is correct (after the autocorrected word)', | ||
| 'Type "Cant" (make sure to misspell it), then press space to autocorrect it. Make sure the cursor position is correct (after the autocorrected word)', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, trying to include a number or boolean as a child in
slate-hyperscriptresulted in an error likeError: Unexpected hyperscript child object: <value>.This PR updates the child handling logic to make number and boolean handling consistent with React JSX. Numbers are converted to strings, and booleans are ignored.
Example
Context
Since JSX is not type-safe, it's quite common to accidentally pass a number instead of a string as a child of a JSX tag when creating JSX dynamically.
Ignoring booleans lets us safely use patterns like
{condition && <element />}.Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)