Skip to content

Conversation

@rraihansaputra
Copy link

@rraihansaputra rraihansaputra commented Jun 29, 2021

Add 3Column-Tall layout variants, based off the 3Column layout but the main pane is split vertically (like Tall splits the screen).

3column-tall.mp4

Requesting comments on:

  • Currently I'm implementing it by adding a Stack variant into the 3Column layout. Please let me know if this adds too much complexity.
  • The name. Is 3Column Tall descriptive enough?

Draft tasks:

  • Modify ThreeColumnLayout to accept and work with mainColumnStack specification
  • register the layout on LayoutType.swift
  • Add tests regarding the Tall variants
    • add tests verifying split on the main column
    • add more thorough tests using the frame verifier
  • Add layout info to README.md

@rraihansaputra rraihansaputra marked this pull request as draft June 29, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants