Skip to content

Use an exponential backoff for the window float delay #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
Merged

Use an exponential backoff for the window float delay #1766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Amethyst/Managers/WindowManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ extension WindowManager {
markAllScreensForReflow(withChange: .none)
}

private func add(window: Window, retries: Int = 5) {
private func add(window: Window, retries: Int = 5, delay: TimeInterval = 0.01) {
guard window.shouldBeManaged() else {
return
}
Expand All @@ -394,8 +394,8 @@ extension WindowManager {

switch application.defaultFloatForWindow(window) {
case .unreliable where retries > 0:
return DispatchQueue.main.asyncAfter(deadline: .now() + 0.05) {
self.add(window: window, retries: retries - 1)
return DispatchQueue.main.asyncAfter(deadline: .now() + delay) {
self.add(window: window, retries: retries - 1, delay: delay * 2)
}
case .reliable(.floating), .unreliable(.floating):
windows.setFloating(true, forWindow: window)
Expand Down
Loading