IBX-11436: Make logic for anchor-menu-items css classes reusable#1868
Open
IBX-11436: Make logic for anchor-menu-items css classes reusable#1868
Conversation
vidarl
changed the title
vidarl
force-pushed
the
IBX-11436_make_main_container_class_in_edit_base_html_twig_reusable
branch
from
d2e09bf to
d7b4484
Compare
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
ibexa-workflow-automation-1
bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick,
dew326 and
tischsoic
and removed request for
a team
vidarl
force-pushed
the
IBX-11436_make_main_container_class_in_edit_base_html_twig_reusable
branch
from
d7b4484 to
270df7f
Compare
vidarl
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
We need to calculate the main container classes in pagebuilder as well. As twig doesn't support importing only one specific block from a given template, I opted for defining the logic in a macro
An alternative could be to move the block to a dedicated template
For QA:
Documentation: