IBX-5533: Switch output to github_action_utils module#2
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the changelog generator action from the deprecated github_action_utils module to the actions-toolkit module, updates authentication methods for GitHub and JIRA APIs, and modernizes the Python environment.
Changes:
- Switched from
github_action_utilstoactions-toolkitfor GitHub Actions output handling - Updated GitHub authentication to use the new
Auth.Tokenmethod - Changed JIRA authentication from Bearer token to basic auth with email and token
- Upgraded Python version from 3.7 to 3.12 and updated base Docker images
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| main.py | Updated imports and API authentication methods for GitHub and JIRA, replaced deprecated output function |
| action.yml | Added jira_email input parameter and switched to building from local Dockerfile |
| Dockerfile | Upgraded Python version and base images, updated dependency versions |
| .github/workflows/python.yml | Updated Python version and GitHub Actions versions in the lint workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| required: false | ||
| default: "alicja.orzel@ibexa.co" |
There was a problem hiding this comment.
Hardcoded email address as default value may expose internal user information. Consider requiring this value to be explicitly provided or using a service account email instead.
| required: false | |
| default: "alicja.orzel@ibexa.co" | |
| required: true |
| print(messages) | ||
| else: | ||
| print(f"::set-output name=changelog::{prepare_output(messages)}") | ||
| gha.set_output("changelog", messages) |
There was a problem hiding this comment.
The prepare_output() function that was previously used to encode newlines for GitHub Actions output has been removed, but the comment on line 154-156 still references the need for this encoding. The actions-toolkit module may handle this automatically, but verify that multiline output is parsed correctly, or keep the prepare_output() call.
| gha.set_output("changelog", messages) | |
| gha.set_output("changelog", prepare_output(messages)) |
No description provided.