Conversation
GrabowskiM
requested review from
OstafinL,
RopRaptor,
albozek,
Copilot,
dew326 and
tischsoic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces and updates a set of design system components including label, input, icon, helper text, expander, button, and accordion to improve styling and consistency.
- Introduces a new label component with dynamic attributes and classes.
- Adds input, icon, and helper text components that utilize helper macros for class and attribute management.
- Updates the expander, button, and accordion components for improved class generation and syntax consistency.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/bundle/Resources/views/themes/standard/design_system/components/label.html.twig | New label component using merged attributes for error and required states. |
| src/bundle/Resources/views/themes/standard/design_system/components/input_text.html.twig | New input component with dynamic class generation and attribute merging. |
| src/bundle/Resources/views/themes/standard/design_system/components/icon.html.twig | Updated icon component with syntax adjustments for variant key definitions. |
| src/bundle/Resources/views/themes/standard/design_system/components/helper_text.html.twig | New helper text component that includes icon rendering via an imported macro. |
| src/bundle/Resources/views/themes/standard/design_system/components/expander.html.twig | Updated expander component with improved class generation patterns. |
| src/bundle/Resources/views/themes/standard/design_system/components/button.html.twig | Updated button component with standardized class assignment and formatting. |
| src/bundle/Resources/views/themes/standard/design_system/components/accordion.html.twig | Updated accordion component with refined class management based on expansion state. |
Comments suppressed due to low confidence (1)
src/bundle/Resources/views/themes/standard/design_system/components/label.html.twig:21
- [nitpick] Consider using the standard 'for' attribute for the label element instead of 'html-for', unless this abstraction is intentional for integrating with framework-specific APIs.
'html-for': html_for,
albozek
approved these changes
Jun 27, 2025
RopRaptor
approved these changes
Jun 27, 2025
tischsoic
approved these changes
Jun 27, 2025
| { | ||
| type | ||
| }, | ||
| classes |
There was a problem hiding this comment.
I would prefer to have here direct reference as this will be less confusing and less error prone.
Suggested change
| classes | |
| attr.class|default('') |
dew326
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: