IBX-11506: Use design-system checkbox/radio/toggle components#74
Open
IBX-11506: Use design-system checkbox/radio/toggle components#74
Conversation
BREAKING CHANGE: Removed reliance on ids-btn--disabled CSS class Button component: - Removed ids-btn--disabled class from button template - Now relies solely on native disabled attribute for styling - Updated tests to verify disabled attribute instead of class Link component: - Added disabled property to Link component - Uses aria-disabled=true attribute for disabled link-buttons - Added test coverage for disabled state - Links styled as buttons now properly support disabled state Why this change: - More semantic HTML - uses native browser attributes - Better accessibility with native disabled/aria-disabled support - Simpler component logic - no class state management needed - CSS already supported attribute selectors Migration guide: - Remove any JavaScript selecting .ids-btn--disabled - Use [disabled] or [aria-disabled] selectors instead - Components automatically handle disabled state via props
…ction in Twig macros
…ion in Twig macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: