Skip to content

IBX-10468: Tests cleanup#12

Merged
GrabowskiM merged 1 commit intomainfrom
IBX-10468
Aug 14, 2025
Merged

IBX-10468: Tests cleanup#12
GrabowskiM merged 1 commit intomainfrom
IBX-10468

Conversation

@GrabowskiM
Copy link
Copy Markdown
Contributor

🎫 Issue IBX-10468

Description:

For QA:

Documentation:

@GrabowskiM GrabowskiM requested a review from Copilot August 7, 2025 14:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up test stories for UI components by standardizing the Storybook configuration and improving code organization. The changes focus on removing redundant argTypes definitions and consolidating common props into the meta-level args configuration.

  • Removes redundant argTypes control configurations that are auto-inferred by Storybook
  • Moves common component props from individual story args to shared meta-level args
  • Updates story names from "TestActive/Primary" to more descriptive "TestEnabled/Enabled" naming

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ClearBtn.test.stories.tsx Removes empty argTypes and renames TestActive story to TestEnabled
InputText.test.stories.tsx Removes argTypes controls, moves name prop to meta args, renames TestActive to Default, adds whitespace formatting
IconButton.test.stories.tsx Removes argTypes, consolidates type/icon props to meta args, renames TestActive to TestEnabled
Expander.test.stories.tsx Removes argTypes controls, moves common labels to meta args
Button.test.stories.tsx Removes argTypes controls, consolidates common props to meta args, renames TestActive to TestEnabled
Accordion.test.stories.tsx Removes initiallyExpanded argTypes control
Comments suppressed due to low confidence (1)

packages/components/src/ui/ClearBtn/ClearBtn.test.stories.tsx:6

  • The Meta type is incorrectly referencing 'Expander' instead of 'ClearBtn'. This should be 'Meta' to match the component being tested.
const meta: Meta<typeof Expander> = {

@GrabowskiM GrabowskiM requested a review from a team August 7, 2025 14:35
@ezrobot ezrobot requested review from OstafinL, RopRaptor, albozek, dew326 and tischsoic and removed request for a team August 7, 2025 14:35
@GrabowskiM GrabowskiM merged commit 270cc10 into main Aug 14, 2025
4 checks passed
@GrabowskiM GrabowskiM deleted the IBX-10468 branch August 14, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants