Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up test stories for UI components by standardizing the Storybook configuration and improving code organization. The changes focus on removing redundant argTypes definitions and consolidating common props into the meta-level args configuration.
- Removes redundant
argTypescontrol configurations that are auto-inferred by Storybook - Moves common component props from individual story args to shared meta-level args
- Updates story names from "TestActive/Primary" to more descriptive "TestEnabled/Enabled" naming
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ClearBtn.test.stories.tsx | Removes empty argTypes and renames TestActive story to TestEnabled |
| InputText.test.stories.tsx | Removes argTypes controls, moves name prop to meta args, renames TestActive to Default, adds whitespace formatting |
| IconButton.test.stories.tsx | Removes argTypes, consolidates type/icon props to meta args, renames TestActive to TestEnabled |
| Expander.test.stories.tsx | Removes argTypes controls, moves common labels to meta args |
| Button.test.stories.tsx | Removes argTypes controls, consolidates common props to meta args, renames TestActive to TestEnabled |
| Accordion.test.stories.tsx | Removes initiallyExpanded argTypes control |
Comments suppressed due to low confidence (1)
packages/components/src/ui/ClearBtn/ClearBtn.test.stories.tsx:6
- The Meta type is incorrectly referencing 'Expander' instead of 'ClearBtn'. This should be 'Meta' to match the component being tested.
const meta: Meta<typeof Expander> = {
albozek
approved these changes
Aug 8, 2025
OstafinL
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: