Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a stateful Higher-Order Component (HOC) for input components, specifically implementing it for the InputText component to manage internal state automatically.
- Creates a
withStateValueHOC that adds internal state management to wrapped components - Introduces
InputTextStatefulas a stateful version ofInputTextusing the new HOC - Updates Storybook stories to use the stateful variant and removes manual state management decorators
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/hoc/withStateValue.tsx | New HOC that provides internal state management for input components |
| packages/components/src/inputs/InputText/index.ts | Exports the new InputTextStateful component alongside the original |
| packages/components/src/inputs/InputText/InputText.tsx | Renames component variable and creates stateful variant using the HOC |
| packages/components/src/inputs/InputText/InputText.test.stories.tsx | Updates test stories to use stateful variant and adds clear button test |
| packages/components/src/inputs/InputText/InputText.stories.tsx | Simplifies stories by using stateful variant and removing manual state decorators |
albozek
approved these changes
Aug 19, 2025
tischsoic
approved these changes
Aug 19, 2025
albozek
approved these changes
Aug 19, 2025
dew326
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: