Skip to content

IBX-7999: Checkbox and ThreeStateCheckbox#16

Merged
dew326 merged 6 commits intomainfrom
IBX-7999
Aug 27, 2025
Merged

IBX-7999: Checkbox and ThreeStateCheckbox#16
dew326 merged 6 commits intomainfrom
IBX-7999

Conversation

@GrabowskiM
Copy link
Copy Markdown
Contributor

@GrabowskiM GrabowskiM commented Aug 18, 2025

🎫 Issue IBX-7999

Related PRs:

Description:

For QA:

Documentation:

@GrabowskiM GrabowskiM requested review from a team and Copilot August 18, 2025 14:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements checkbox components by introducing a basic Checkbox component and a ThreeStateCheckbox component that extends it with indeterminate state support. The implementation includes proper styling, ref forwarding, and comprehensive Storybook documentation.

  • Added Checkbox component with standard checkbox functionality and proper event handling
  • Added ThreeStateCheckbox component that extends Checkbox to support indeterminate state
  • Enhanced BaseInput component to support ref forwarding for the new checkbox implementations

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/components/src/internal/partials/BaseInput/BaseInput.types.ts Added Ref type import and ref prop to support forwarding refs to input elements
packages/components/src/internal/partials/BaseInput/BaseInput.tsx Added ref prop handling to forward refs to the underlying input element
packages/components/src/inputs/Checkbox/*.tsx Implemented basic Checkbox component with proper event handling and styling
packages/components/src/inputs/ThreeStateCheckbox/*.tsx Implemented ThreeStateCheckbox extending Checkbox with indeterminate state support
packages/assets/src/scss/inputs/_checkbox.scss Added comprehensive CSS styling for checkbox states including indeterminate
packages/assets/src/scss/styles.scss Imported checkbox styles into the main stylesheet

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dew326 dew326 merged commit afa8f4b into main Aug 27, 2025
4 checks passed
@dew326 dew326 deleted the IBX-7999 branch August 27, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants