Conversation
OstafinL
reviewed
Aug 26, 2025
OstafinL
reviewed
Aug 26, 2025
tischsoic
approved these changes
Aug 26, 2025
a786616 to
93901ac
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new RadioButton component by refactoring the existing BaseCheckbox into a more generic BaseChoiceInput that supports both checkbox and radio input types.
- Refactored BaseCheckbox to BaseChoiceInput to support both checkbox and radio input types
- Created a new RadioButton component with full Storybook documentation and tests
- Updated existing Checkbox and ThreeStateCheckbox components to use the new BaseChoiceInput
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/partials/BaseChoiceInput/ | New generic base component replacing BaseCheckbox with type parameter |
| packages/components/src/inputs/RadioButton/ | New RadioButton component implementation with stories and tests |
| packages/components/src/inputs/Checkbox/ | Updated to use BaseChoiceInput instead of BaseCheckbox |
| packages/components/src/inputs/ThreeStateCheckbox/ | Updated to use BaseChoiceInput with proper type omission |
| packages/assets/src/scss/ | Added radio button styles and extracted common choice input mixins |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/components/src/inputs/RadioButton/RadioButton.test.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/inputs/RadioButton/RadioButton.test.stories.tsx
Outdated
Show resolved
Hide resolved
tischsoic
approved these changes
Aug 28, 2025
OstafinL
approved these changes
Aug 28, 2025
dew326
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: