Skip to content

IBX-7874: Radio button#18

Merged
dew326 merged 2 commits intomainfrom
IBX-7874
Aug 29, 2025
Merged

IBX-7874: Radio button#18
dew326 merged 2 commits intomainfrom
IBX-7874

Conversation

@GrabowskiM
Copy link
Copy Markdown
Contributor

@GrabowskiM GrabowskiM commented Aug 25, 2025

🎫 Issue IBX-7874

Related PRs:

Description:

For QA:

Documentation:

@GrabowskiM GrabowskiM requested review from a team and Copilot August 25, 2025 09:28

This comment was marked as outdated.

@GrabowskiM GrabowskiM force-pushed the IBX-7999 branch 2 times, most recently from a786616 to 93901ac Compare August 27, 2025 12:02
Base automatically changed from IBX-7999 to main August 27, 2025 12:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new RadioButton component by refactoring the existing BaseCheckbox into a more generic BaseChoiceInput that supports both checkbox and radio input types.

  • Refactored BaseCheckbox to BaseChoiceInput to support both checkbox and radio input types
  • Created a new RadioButton component with full Storybook documentation and tests
  • Updated existing Checkbox and ThreeStateCheckbox components to use the new BaseChoiceInput

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/components/src/internal/partials/BaseChoiceInput/ New generic base component replacing BaseCheckbox with type parameter
packages/components/src/inputs/RadioButton/ New RadioButton component implementation with stories and tests
packages/components/src/inputs/Checkbox/ Updated to use BaseChoiceInput instead of BaseCheckbox
packages/components/src/inputs/ThreeStateCheckbox/ Updated to use BaseChoiceInput with proper type omission
packages/assets/src/scss/ Added radio button styles and extracted common choice input mixins

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dew326 dew326 merged commit ceedc4e into main Aug 29, 2025
4 checks passed
@dew326 dew326 deleted the IBX-7874 branch August 29, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants