Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new BaseFormControl component that provides a reusable wrapper for form controls with optional label and helper text. The component serves as a foundational building block for form elements in the design system.
- Added BaseFormControl React component with TypeScript types and proper export structure
- Created corresponding SCSS styles for form control layout and spacing
- Updated helper text font size from medium to small for better visual hierarchy
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/partials/BaseFormControl/index.ts | Export file for the BaseFormControl component and its types |
| packages/components/src/internal/partials/BaseFormControl/BaseFormControl.types.ts | TypeScript interface definitions for BaseFormControl props |
| packages/components/src/internal/partials/BaseFormControl/BaseFormControl.tsx | Main React component implementation with label and helper text rendering |
| packages/assets/src/scss/styles.scss | Updated imports to include new form-control styles and reorganized helper-text import |
| packages/assets/src/scss/_helper-text.scss | Reduced font size from medium to small for helper text |
| packages/assets/src/scss/_form-control.scss | New SCSS file defining spacing styles for form control wrappers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| export interface BaseFormControlProps extends BaseComponentAttributes { | ||
| children: ReactNode; | ||
| type: string; |
There was a problem hiding this comment.
The type prop uses a generic string type which allows any value. Consider using a union type or enum to restrict valid form control types and improve type safety.
Suggested change
| type: string; | |
| type: 'text' | 'password' | 'email' | 'number' | 'search' | 'tel' | 'url' | 'date' | 'datetime-local' | 'month' | 'week' | 'time' | 'checkbox' | 'radio' | 'file' | 'range' | 'color' | 'hidden' | 'submit' | 'reset' | 'button'; |
packages/components/src/internal/partials/BaseFormControl/BaseFormControl.tsx
Outdated
Show resolved
Hide resolved
OstafinL
approved these changes
Aug 26, 2025
OstafinL
approved these changes
Aug 26, 2025
albozek
approved these changes
Aug 26, 2025
dew326
approved these changes
Aug 26, 2025
tischsoic
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: