Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a shared base component for form control list components. It creates a reusable BaseInputsList component that can render lists of form inputs with configurable direction (horizontal/vertical) and optional label/helper text support.
- Creates a generic
BaseInputsListcomponent with TypeScript support for type-safe item rendering - Adds direction configuration (horizontal/vertical) for flexible layout options
- Includes comprehensive Storybook stories for documentation and testing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/partials/BaseInputsList/index.ts | Main export file for the BaseInputsList component |
| packages/components/src/internal/partials/BaseInputsList/BaseInputsList.types.ts | TypeScript type definitions and DIRECTION enum |
| packages/components/src/internal/partials/BaseInputsList/BaseInputsList.tsx | Core component implementation with generic type support |
| packages/components/src/internal/partials/BaseInputsList/BaseInputsList.stories.tsx | Storybook stories for component documentation |
| packages/assets/src/scss/styles.scss | Import statement for new SCSS module |
| packages/assets/src/scss/_inputs-list.scss | Styling for the inputs list component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/components/src/internal/partials/BaseInputsList/BaseInputsList.tsx
Show resolved
Hide resolved
OstafinL
approved these changes
Sep 2, 2025
albozek
approved these changes
Sep 2, 2025
dew326
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: