Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a typography system for the design system, creating Storybook stories to showcase different font styles, weights, and sizes. The changes establish comprehensive typography documentation with visual examples for headers, base text, and links.
Key changes:
- Added typography Storybook stories with visual documentation tables
- Introduced new font weight variables and Work Sans font face
- Created link styling components and updated build configuration
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/typography/Typography.stories.tsx | Main Storybook story component that renders typography examples |
| stories/typography/TypographyBase.tsx | Component displaying base font examples with different sizes and weights |
| stories/typography/TypographyHeaders.tsx | Component showing header typography examples |
| stories/typography/TypographyLinks.tsx | Component demonstrating link typography styles |
| stories/typography/typography.styles.scss | SCSS file defining typography-related CSS classes and styling |
| packages/assets/src/scss/variables/_typography.scss | Added font weight variables for normal and semi-bold |
| packages/assets/src/scss/_links.scss | New stylesheet for link component styling |
| packages/assets/src/scss/_fonts.scss | Updated font face definitions, replaced bold with Work Sans |
| packages/assets/src/scss/styles.scss | Added imports for headers and links stylesheets |
| .storybook/main.js | Updated stories glob pattern and added alias for core components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
albozek
approved these changes
Sep 3, 2025
OstafinL
approved these changes
Sep 8, 2025
dew326
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: