Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new base component BaseChoiceInputWithLabel that provides a structured wrapper for choice inputs (like radio buttons and checkboxes) with associated labels. The component aims to standardize the layout and styling of choice inputs across the design system.
- Creates a new
BaseChoiceInputWithLabelcomponent with TypeScript support and Storybook documentation - Updates the existing
BaseChoiceInputcomponent to use consistent CSS class naming patterns - Adds corresponding SCSS styles for the new components with proper spacing and alignment
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/components/src/internal/partials/BaseChoiceInputWithLabel/index.ts |
Exports the new component and its TypeScript types |
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.types.ts |
Defines TypeScript interface for component props |
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.tsx |
Main component implementation with label and input wrapper |
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.stories.tsx |
Storybook stories for component documentation |
packages/components/src/internal/partials/BaseChoiceInput/BaseChoiceInput.tsx |
Updates existing component to use consistent CSS class naming |
packages/assets/src/scss/styles.scss |
Imports new SCSS files for styling |
packages/assets/src/scss/_choice-input.scss |
Adds base styling for choice input components |
packages/assets/src/scss/_choice-input-with-label.scss |
Adds styling for the new wrapper component |
packages/assets/src/scss/_choice-input-label.scss |
Updates label styling with cursor pointer |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.types.ts
Show resolved
Hide resolved
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.tsx
Outdated
Show resolved
Hide resolved
OstafinL
approved these changes
Sep 3, 2025
albozek
approved these changes
Sep 3, 2025
08639d8 to
e0d8863
Compare
dew326
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: