Skip to content

IBX-10606: Base ChoiceInput with Label#27

Merged
dew326 merged 2 commits intomainfrom
IBX-10606
Sep 3, 2025
Merged

IBX-10606: Base ChoiceInput with Label#27
dew326 merged 2 commits intomainfrom
IBX-10606

Conversation

@GrabowskiM
Copy link
Copy Markdown
Contributor

🎫 Issue IBX-10606

Related PRs:

Description:

For QA:

Documentation:

@GrabowskiM GrabowskiM requested review from a team and Copilot September 3, 2025 12:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new base component BaseChoiceInputWithLabel that provides a structured wrapper for choice inputs (like radio buttons and checkboxes) with associated labels. The component aims to standardize the layout and styling of choice inputs across the design system.

  • Creates a new BaseChoiceInputWithLabel component with TypeScript support and Storybook documentation
  • Updates the existing BaseChoiceInput component to use consistent CSS class naming patterns
  • Adds corresponding SCSS styles for the new components with proper spacing and alignment

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/components/src/internal/partials/BaseChoiceInputWithLabel/index.ts Exports the new component and its TypeScript types
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.types.ts Defines TypeScript interface for component props
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.tsx Main component implementation with label and input wrapper
packages/components/src/internal/partials/BaseChoiceInputWithLabel/BaseChoiceInputWithLabel.stories.tsx Storybook stories for component documentation
packages/components/src/internal/partials/BaseChoiceInput/BaseChoiceInput.tsx Updates existing component to use consistent CSS class naming
packages/assets/src/scss/styles.scss Imports new SCSS files for styling
packages/assets/src/scss/_choice-input.scss Adds base styling for choice input components
packages/assets/src/scss/_choice-input-with-label.scss Adds styling for the new wrapper component
packages/assets/src/scss/_choice-input-label.scss Updates label styling with cursor pointer

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ezrobot ezrobot requested review from OstafinL, RopRaptor, albozek, dew326 and tischsoic and removed request for a team September 3, 2025 12:35
Base automatically changed from IBX-10604 to main September 3, 2025 13:41
@dew326 dew326 merged commit 49f3fd6 into main Sep 3, 2025
4 checks passed
@dew326 dew326 deleted the IBX-10606 branch September 3, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants