IBX-10151: [Storybook] Story to preview colors used in Design System#3
Merged
IBX-10151: [Storybook] Story to preview colors used in Design System#3
Conversation
GrabowskiM
requested review from
OstafinL,
RopRaptor,
albozek,
Copilot,
dew326 and
tischsoic
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Colors story for development purposes and updates the Storybook tags for several components.
- Added a Colors.stories.tsx file to visualize SCSS color variables in a table.
- Updated Storybook tags to include additional classification labels (e.g., foundation, buttons, in-frequent, secondary) across various component stories.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stories/Colors.stories.tsx | New story to display colors with a basic search filter. |
| packages/components/src/Icon/Icon.stories.tsx | Added "foundation" tag to existing autodocs tag. |
| packages/components/src/Expander/Expander.stories.tsx | Added "buttons" tag to existing autodocs tag. |
| packages/components/src/Button/Button.stories.tsx | Added "foundation" and "buttons" tags to autodocs tag. |
| packages/components/src/Autosave/Autosave.stories.tsx | Added "in-frequent" tag to autodocs tag. |
| packages/components/src/Accordion/Accordion.stories.tsx | Added "secondary" tag to autodocs tag. |
Comments suppressed due to low confidence (1)
stories/Colors.stories.tsx:27
- [nitpick] The variable name 'iconsRows' is misleading since the data represents colors rather than icons. Consider renaming it to 'colorRows' for clarity.
const iconsRows = colorsList.filter(({ name }) => searchValue === '' || name.includes(searchValue)).map(({ name, hex }) => {
| layout: 'centered', | ||
| }, | ||
| tags: ['autodocs'], | ||
| tags: ['autodocs', 'in-frequent'], |
There was a problem hiding this comment.
[nitpick] The tag 'in-frequent' appears to be unusually hyphenated. Consider using 'infrequent' unless the current spelling is intentional.
Suggested change
| tags: ['autodocs', 'in-frequent'], | |
| tags: ['autodocs', 'infrequent'], |
GrabowskiM
changed the title
OstafinL
approved these changes
Jun 11, 2025
albozek
approved these changes
Jun 16, 2025
dew326
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Colors Story is only for dev purposes; it's quite raw as there are currently no styles for inputs and tables.
This PR also introduces tags for all components - based on function requirements steps.
For QA:
Documentation: