Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a RadioButtonsList component for form controls, providing a reusable way to render multiple radio buttons with consistent styling and behavior.
- Adds new RadioButtonsList component with supporting types and HOC improvements
- Enhances RadioButton component with required value prop
- Creates comprehensive Storybook stories for the new component
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/hoc/withStateValue.tsx | Refactored HOC to support better type safety with separate Props and ValueType generics |
| packages/components/src/inputs/RadioButton/RadioButton.types.ts | Added required value prop to RadioButtonProps |
| packages/components/src/inputs/RadioButton/RadioButton.stories.tsx | Added value prop to RadioButton stories |
| packages/components/src/formControls/RadioButtonsList/index.ts | Created barrel export for RadioButtonsList component |
| packages/components/src/formControls/RadioButtonsList/RadioButtonsList.types.ts | Defined types and interfaces for RadioButtonsList component |
| packages/components/src/formControls/RadioButtonsList/RadioButtonsList.tsx | Implemented main RadioButtonsList component with stateful variant |
| packages/components/src/formControls/RadioButtonsList/RadioButtonsList.stories.tsx | Created comprehensive Storybook stories for all component variants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/components/src/formControls/RadioButtonsList/RadioButtonsList.types.ts
Outdated
Show resolved
Hide resolved
packages/components/src/formControls/RadioButtonsList/RadioButtonsList.tsx
Outdated
Show resolved
Hide resolved
0ca198a to
f16b26a
Compare
f16b26a to
ace971c
Compare
OstafinL
approved these changes
Sep 5, 2025
albozek
approved these changes
Sep 5, 2025
dew326
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: