Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ibexa Notifications #3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.0
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Ibexa Notifications #3090
Changes from all commits
89296c00e7ca02a137ac0c3936c543b3df896f9146ffe904d0d9abdca76baed233029ef5dd2d97aa8f3aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 39 in code_samples/user_management/notifications/src/Command/NotificationSenderCommand.php
Define and throw a dedicated exception instead of using a generic one.
Check warning on line 49 in code_samples/user_management/notifications/src/Notifications/CommandExecuted.php
Extract this nested ternary operation into an independent statement.
Check failure on line 59 in docs/administration/back_office/notifications.md
[vale] docs/administration/back_office/notifications.md#L59
Raw output
{"message": "[Ibexa.Spellcheck] Did you really mean 'createStruct'?", "location": {"path": "docs/administration/back_office/notifications.md", "range": {"start": {"line": 59, "column": 107}}}, "severity": "ERROR"}Check notice on line 10 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L10
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 10, "column": 30}}}, "severity": "INFO"}Check failure on line 10 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L10
Raw output
{"message": "[Ibexa.DomainTerms] Use 'back office' instead of 'AdminUi'", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 10, "column": 218}}}, "severity": "ERROR"}Check notice on line 48 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L48
Raw output
{"message": "[Ibexa.Whether] Consider replacing 'if' with 'whether' for clarity", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 48, "column": 77}}}, "severity": "INFO"}Check warning on line 50 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L50
Raw output
{"message": "[Ibexa.FirstPersonPronouns] Do not use first person pronouns unless specifically referring to our company.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 50, "column": 55}}}, "severity": "WARNING"}Check notice on line 66 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L66
Raw output
{"message": "[Ibexa.ArticlesInHeadings] Avoid articles in headings.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 66, "column": 11}}}, "severity": "INFO"}Check notice on line 68 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L68
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 68, "column": 30}}}, "severity": "INFO"}Check notice on line 70 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L70
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 70, "column": 78}}}, "severity": "INFO"}Check notice on line 75 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L75
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 75, "column": 61}}}, "severity": "INFO"}Check failure on line 76 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L76
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 76, "column": 19}}}, "severity": "ERROR"}Check warning on line 95 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L95
Raw output
{"message": "[Ibexa.EOLWhitespace] Remove whitespace characters from the end of the line.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 95, "column": 79}}}, "severity": "WARNING"}Check notice on line 97 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L97
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 97, "column": 46}}}, "severity": "INFO"}Check notice on line 98 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L98
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 98, "column": 4}}}, "severity": "INFO"}Check notice on line 98 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L98
Raw output
{"message": "[Ibexa.Passive] Try to avoid passive tense, when possible.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 98, "column": 59}}}, "severity": "INFO"}Check notice on line 119 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L119
Raw output
{"message": "[Ibexa.ArticlesInHeadings] Avoid articles in headings.", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 119, "column": 11}}}, "severity": "INFO"}Check failure on line 121 in docs/users/notification_channels.md
[vale] docs/users/notification_channels.md#L121
Raw output
{"message": "[Ibexa.Spellcheck] Did you really mean 'shortname'?", "location": {"path": "docs/users/notification_channels.md", "range": {"start": {"line": 121, "column": 144}}}, "severity": "ERROR"}Uh oh!
There was an error while loading. Please reload this page.