Skip to content

Comments

Support copy from right in timetable editor#1013

Merged
miles-grant-ibigroup merged 3 commits intodevfrom
timetable-new-features
Jan 7, 2025
Merged

Support copy from right in timetable editor#1013
miles-grant-ibigroup merged 3 commits intodevfrom
timetable-new-features

Conversation

@miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Timetable editor has a cool keyboard shortcut to copy from left/top, but nothing to copy from right! We add shift+l to do this, mirroring shift+'.

Please test thoroughly I could only come up with so many edge cases. Tempted to add a new e2e case

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add null checks and a check to avoid copying time into a non-time cell.

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@miles-grant-ibigroup miles-grant-ibigroup merged commit f044bbb into dev Jan 7, 2025
5 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the timetable-new-features branch January 7, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants