Location Groups July 2024#1017
Merged
miles-grant-ibigroup merged 25 commits intodev-flex-2024from Feb 19, 2025
Merged
Conversation
7 tasks
miles-grant-ibigroup
added
WIP
BLOCKED
fix: define and document MAP_BASE_URL to prevent gray maps
|
Excited for this update! |
miles-grant-ibigroup
removed
the
BLOCKED
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
First round of comments.
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Next round of comments...
binh-dam-ibigroup
approved these changes
Feb 10, 2025
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Nice cleaning up the interim flex stuff and improving the types. I am going to give the benefit of doubt regarding the flow stuff. There are few nits but nothing fundamentally blocking.
| zone_id?: string | ||
| |} | ||
|
|
||
| // export type GtfsLocationGroup = { |
Contributor
There was a problem hiding this comment.
Do we need this type?
Contributor
Author
There was a problem hiding this comment.
We'll need it to show location groups on the map.
josh-willis-arcadis
approved these changes
Feb 18, 2025
Contributor
josh-willis-arcadis
left a comment
josh-willis-arcadis
left a comment
There was a problem hiding this comment.
Nothing major from me. Code looks good.
| </Form> | ||
| </div> | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
nit. remove extra space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location Group support following latest flex spec. Works with data tools-server
dev-flexbranch