track non-seekable stream size as usize in yyjson_read_fp#284
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 2 2
Lines 7726 7728 +2
=======================================
+ Hits 7614 7616 +2
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thank you for the review and merge. Appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yyjson_read_fp keeps the running byte count of a non-seekable stream in a signed long, while the buffer length itself is a usize that is overflow-checked as it grows. on builds where long is narrower than size_t (LLP64, and 32-bit targets) a stream larger than LONG_MAX wraps that counter negative, so the trailing memset writes before the buffer and yyjson_read_opts is handed a bogus length, reading and writing out of bounds. track the byte count in a usize alongside buf_size so it cannot overflow before the already-guarded buffer length does.