Skip to content

Commit 85d149f

Browse files
committed
chore: remove more unused fixtures
1 parent 4d8e124 commit 85d149f

File tree

2 files changed

+26
-33
lines changed

2 files changed

+26
-33
lines changed

ibis/backends/tests/sql/test_sql.py

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -90,45 +90,45 @@ def test_comparisons(functional_alltypes, opname, snapshot):
9090

9191

9292
@pytest.mark.parametrize(
93-
"opname, dtype, associative",
93+
("opname", "dtype"),
9494
[
9595
param(*v, id=f"{v[0]}-{v[1]}")
9696
for v in [
9797
# Numeric
98-
("add", "int8", True),
99-
("mul", "int8", True),
100-
("sub", "int8", False),
101-
("truediv", "int8", False),
102-
("mod", "int8", False),
103-
("pow", "int8", False),
104-
("and_", "int8", True),
105-
("or_", "int8", True),
106-
("xor", "int8", True),
107-
("lshift", "int8", False),
108-
("rshift", "int8", False),
98+
("add", "int8"),
99+
("mul", "int8"),
100+
("sub", "int8"),
101+
("truediv", "int8"),
102+
("mod", "int8"),
103+
("pow", "int8"),
104+
("and_", "int8"),
105+
("or_", "int8"),
106+
("xor", "int8"),
107+
("lshift", "int8"),
108+
("rshift", "int8"),
109109
# Logical
110-
("and_", "bool", True),
111-
("or_", "bool", True),
112-
("xor", "bool", True),
110+
("and_", "bool"),
111+
("or_", "bool"),
112+
("xor", "bool"),
113113
# Date
114-
("add", "date,interval('D')", True),
115-
("sub", "date,interval('D')", False),
114+
("add", "date,interval('D')"),
115+
("sub", "date,interval('D')"),
116116
# Time
117-
("add", "time,interval", True),
118-
("sub", "time,interval", False),
117+
("add", "time,interval"),
118+
("sub", "time,interval"),
119119
# Timestamp
120-
("add", "timestamp,interval", True),
121-
("sub", "timestamp,interval", False),
120+
("add", "timestamp,interval"),
121+
("sub", "timestamp,interval"),
122122
# Interval
123-
("add", "interval", True),
124-
("sub", "interval", False),
125-
("mul", "interval,int8", True),
123+
("add", "interval"),
124+
("sub", "interval"),
125+
("mul", "interval,int8"),
126126
]
127127
],
128128
)
129129
def test_binop_parens(snapshot, opname, dtype):
130130
op = getattr(operator, opname)
131-
dtypes = [ibis.dtype(d) for d in dtype.split(",")]
131+
dtypes = list(map(ibis.dtype, dtype.split(",")))
132132
while len(dtypes) < 3:
133133
dtypes.append(dtypes[-1]) # repeat last dtype
134134

ibis/tests/expr/test_timestamp.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,7 @@ def test_timestamp_field_access_on_date(
125125

126126

127127
@pytest.mark.parametrize(
128-
("field", "expected_operation", "expected_type"),
129-
[
130-
("hour", ops.ExtractHour, ir.IntegerColumn),
131-
("minute", ops.ExtractMinute, ir.IntegerColumn),
132-
("second", ops.ExtractSecond, ir.IntegerColumn),
133-
("microsecond", ops.ExtractMicrosecond, ir.IntegerColumn),
134-
("millisecond", ops.ExtractMillisecond, ir.IntegerColumn),
135-
],
128+
"field", ["hour", "minute", "second", "microsecond", "millisecond"]
136129
)
137130
def test_timestamp_field_access_on_date_failure(field, alltypes):
138131
time_col = alltypes.i.date()

0 commit comments

Comments
 (0)