Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): update common typing to skip non-existent attributes #10666

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Update test_typing.py

2827077
Select commit
Loading
Failed to load commit list.
Open

fix(typing): update common typing to skip non-existent attributes #10666

Update test_typing.py
2827077
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 10, 2025 in 0s

66.66% of diff hit (within 92.00% threshold of 94.12%)

View this Pull Request on Codecov

66.66% of diff hit (within 92.00% threshold of 94.12%)

Annotations

Check warning on line 65 in ibis/common/typing.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/common/typing.py#L65

Added line #L65 was not covered by tests

Check warning on line 67 in ibis/common/typing.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/common/typing.py#L67

Added line #L67 was not covered by tests

Check warning on line 13 in ibis/tests/test_typing.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/tests/test_typing.py#L13

Added line #L13 was not covered by tests

Check warning on line 17 in ibis/tests/test_typing.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/tests/test_typing.py#L17

Added line #L17 was not covered by tests

Check warning on line 22 in ibis/tests/test_typing.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/tests/test_typing.py#L21-L22

Added lines #L21 - L22 were not covered by tests