fix(impala): make create_database follow the CanCreateDatabase API #11149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCrews
added
impala
NickCrews
force-pushed
the
impala-can-create-database
branch
from
43141e1 to
cc932dd
Compare
NickCrews
force-pushed
the
impala-can-create-database
branch
from
cc932dd to
5bfa090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to a bug I found in #11112.
In that PR, I added CanCreateDatabase as a superclass of Impala, and then tests started failing. So I'm trying to fix this here.
This is a breaking change by renaming the params of the funciton and making the kwarg-only