Skip to content

docs: add examples of .isin(<contains NULL>) #11154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NickCrews
Copy link
Contributor

@NickCrews NickCrews commented Apr 24, 2025

Related to #11153

Also adds examples for .notin()

@NickCrews NickCrews changed the title docs: add examples of when haystack includes NULL in .isin() and .notin() docs: add examples of .isin(<contains NULL>) Apr 24, 2025
@NickCrews NickCrews requested a review from Copilot April 24, 2025 17:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the docstrings for the isin and notin methods to include detailed examples demonstrating how NULL values are handled when present in the input values.

  • Updated the isin method’s docstring to clarify that NULL values in the input propagate and to include memtable-based examples.
  • Updated the notin method’s docstring similarly, with detailed examples covering literal values, same table columns, and columns from another table.

@NickCrews NickCrews force-pushed the isin-null-docstring branch from b11463b to 52c677e Compare May 7, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant