fix(snowflake): allow expressions in window bounds #11623
Merged
+1
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes an overly restrictive check in the Snowflake SQL compiler that prevented expressions from being used in window bounds.
Snowflake added support for expressions in window bounds in August 2024 (release notes), but Ibis was still raising
OperationNotDefinedError
when trying to use interval expressions likeibis.interval(seconds=10)
.Before:
OperationNotDefinedError: Expressions in window bounds are not supported by Snowflake
After: Generates correct SQL like
RANGE BETWEEN INTERVAL '10 SECOND' preceding AND INTERVAL '0 SECOND' following
The fix removes the restriction and lets the base class handle window boundary processing, matching the behavior of other SQL backends.
Issues closed
N/A - This addresses a compatibility issue with current Snowflake.