fix(devcontainers): replace broken packages, improve usability#12029
Open
JonAnCla wants to merge 2 commits into
Open
fix(devcontainers): replace broken packages, improve usability#12029JonAnCla wants to merge 2 commits into
JonAnCla wants to merge 2 commits into
Conversation
- openjdk-17-jdk not present on base python image - file edits made within container not reflected back to the host - COPY + RUN chown commands slow - remove duckdb-cli feature which no longer builds with duckdb 1.5.x version
Contributor
Author
|
sorry for typo in title (fic should be fix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I've found devcontainers to be particularly useful for local development with AI tools (to reduce risk of them doing something damaging or exfiltrating other files on your system)
In trying to use the existing devcontainer config in ibis, I found following issues:
RUN chown ...command is very slowChanges below were made (I guided Claude) to address the above
Dockerfiledevcontainer.jsonThanks!