This repository was archived by the owner on Dec 14, 2023. It is now read-only.
test: replace add_date() calls in TPC-H queries with Ibis function calls#15
Open
ianmcook wants to merge 3 commits intoibis-project:masterfrom
Open
test: replace add_date() calls in TPC-H queries with Ibis function calls#15ianmcook wants to merge 3 commits intoibis-project:masterfrom
add_date() calls in TPC-H queries with Ibis function calls#15ianmcook wants to merge 3 commits intoibis-project:masterfrom
Conversation
add_date()calls in TPC-H queries with Ibis method callsadd_date()calls in TPC-H queries with Ibis function calls
add_date()calls in TPC-H queries with Ibis function callsadd_date() calls in TPC-H queries with Ibis function calls
Author
|
I'll look at the test failures and make some changes |
Member
|
I think you can remove the The |
Author
|
@gforsyth should I make any changes here based on the additions in ibis-project/ibis#6003? |
Member
|
@ianmcook -- so I think the only things we can do here are:
But that will mean that ibis-master will be a defacto requirement of running this helper with |
Author
|
Waiting seems fine to me. This is not urgent at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working with dates in Ibis and noticed that the TPC-H queries in this repo do literal date +/- interval math using a utility function that uses Python's datetime and dateutil. I reimplemented that all here using
ibis.date()+/-ibis.interval().In 31bb61f I added a bunch of
.cast("date")but I'm not sure whether they are needed. It was super unclear to me whether the date columns are stored as dates or as strings.