Add separate beacon trust flow#297
Open
dniku wants to merge 1 commit into
Open
Conversation
dniku
force-pushed
the
beacon-trust-flow
branch
5 times, most recently
from
8f14398 to
f2757a5
Compare
Motivation: The on-premise install flow previously used the final host trust path while talking to the beacon. The beacon boots with its own generated SSH host key, so treating it like the final host makes the trust boundary ambiguous and can train users or tests to accept the wrong key during installation. Design: Introduce a dedicated beacon trust file, `<host>/beacon_known_hosts`, and make all beacon-specific commands use the `<host>-beacon` alias against that file. The normal final-host `known_hosts` file remains separate. The new trust command scans the beacon key, shows fingerprints, writes the beacon trust file only after confirmation or `--yes`, and requires `--force` when replacing a different trusted beacon key. Implemented changes: Add `<host>-beacon-trust`, `<host>-beacon-ssh`, `<host>-beacon-get-facter`, and `<host>-beacon-install`. Keep the old `<host>-get-facter` and `<host>-install-on-beacon` names as deprecated aliases with stderr warnings. Document the new flow, ignore generated `beacon_known_hosts` files in the template, and update VM tests to use the new beacon commands, verify that the final host key is rejected for beacon SSH, and use a bounded beacon-trust startup loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The on-premise install flow previously used the final host trust path while talking to the beacon. The beacon boots with its own generated SSH host key, so treating it like the final host makes the trust boundary ambiguous and can train users or tests to accept the wrong key during installation.
Design
Introduce a dedicated beacon trust file,
<host>/beacon_known_hosts, and make all beacon-specific commands use the<host>-beaconalias against that file. The normal final-hostknown_hostsfile remains separate. The new trust command scans the beacon key, shows fingerprints, writes the beacon trust file only after confirmation or--yes, and requires--forcewhen replacing a different trusted beacon key.Implemented changes
Add
<host>-beacon-trust,<host>-beacon-ssh,<host>-beacon-get-facter, and<host>-beacon-install. Keep the old<host>-get-facterand<host>-install-on-beaconnames as deprecated aliases with stderr warnings. Document the new flow, ignore generatedbeacon_known_hostsfiles in the template, and update VM tests to use the new beacon commands, verify that the final host key is rejected for beacon SSH, and use a bounded beacon-trust startup loop.Fixes #267.