[major] add support for elasticsearch 9.x.x#31
Conversation
Signed-off-by: Daniel Istrate <daniel.istrate@ymail.com>
| ## License | ||
|
|
||
| Copyright 2020, 2023 IBM Corporation | ||
| Copyright 2020, 2026 IBM Corporation |
There was a problem hiding this comment.
The copyright should be appended not a amended
2020, 2023, 2026
There was a problem hiding this comment.
I don't think this file is required
| * Apache Kafka 2.0.0 or later, either standalone or included as part of an offering such as IBM Event Streams | ||
| * Elasticsearch 7.0.0 or later | ||
| * Apache Kafka 4.2.0 or later, either standalone or included as part of an offering such as IBM Event Streams | ||
| * Elasticsearch 7.0.0 or later (tested and compatible with Elasticsearch 9.4.1) |
There was a problem hiding this comment.
I don't think we should specify which version we tested on, it would give an impression that it was tested only with 9.4.1
|
|
||
| public class Version { | ||
| public static final String VERSION = "1.0.3"; // Must match the value in pom.xml | ||
| public static final String VERSION = "2.0.0"; // Must match the value in pom.xml - Updated for Elasticsearch 9.x compatibility |
There was a problem hiding this comment.
can you please remove - Updated for Elasticsearch 9.x compatibility
| @@ -506,10 +506,11 @@ private HttpClient setupConnection() { | |||
| throw new ConnectException(e); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
please remove Elasticsearch 9.x compatibility
There was a problem hiding this comment.
We don’t keep changelogs as a separate file; we usually add this information to the release description. It’s totally fine if we add one, but the dates might be misaligned, as the release date may not match what’s mentioned in the file. I think it’s best to remove this file, as we don’t want to duplicate information or add the burden of maintaining it for each release.
There was a problem hiding this comment.
We don't keep changelogs as a seperate file, we usually add this information to the release description. its ok if we add it but the dates might miss align as the date we release won't the match what is there in the file
There was a problem hiding this comment.
Can you please add 2026 to the copyright header
There was a problem hiding this comment.
Can you please add 2026 to the copyright header
Major Updates
Dependency Changes
Code Changes
ElasticWriter.javato support both TLS 1.2 and TLS 1.3 protocolsBuild Configuration
com.ibm.eventstreams.shaded.jettypackageTesting
quickstartSnap from test:

Breaking Changes