Create new parameter "mq.encoding" to override the destination character set#43
Open
tokunagadaniel wants to merge 2 commits into
Open
Create new parameter "mq.encoding" to override the destination character set#43tokunagadaniel wants to merge 2 commits into
tokunagadaniel wants to merge 2 commits into
Conversation
brenofr
approved these changes
Jul 22, 2021
thoudahl
approved these changes
Dec 6, 2022
thoudahl
left a comment
thoudahl
left a comment
There was a problem hiding this comment.
Besides changing import order and style it looks good.
I would really appreciate this feature as well!
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.jms.*; |
There was a problem hiding this comment.
Could instead be:
import javax.jms.DeliveryMode; import javax.jms.JMSContext; import javax.jms.JMSException; import javax.jms.JMSProducer; import javax.jms.JMSRuntimeException; import javax.jms.Message;
Like it was before.
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.jms.*; | ||
| import javax.net.ssl.*; |
There was a problem hiding this comment.
Could instead be:
import javax.net.ssl.KeyManager; import javax.net.ssl.KeyManagerFactory; import javax.net.ssl.SSLContext; import javax.net.ssl.TrustManager; import javax.net.ssl.TrustManagerFactory;
Like it was before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the website: jms encoding
"An application can override the destination character set by setting the message property JMS_IBM_CHARACTER_SET. JMS_IBM_CHARACTER_SET, when sending a message must be a numeric coded character set identifier2."