fix: loading error pages after building shared config#102
Merged
StokesAsselborn merged 1 commit intodevfrom Jan 13, 2026
Merged
fix: loading error pages after building shared config#102StokesAsselborn merged 1 commit intodevfrom
StokesAsselborn merged 1 commit intodevfrom
Conversation
Collaborator
Author
|
To test : |
files for testing route specific error_pages
b2d1f25 to
6d97f55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid going touching the SharedConfig struct and modifying the handlers etc, we are now doing the following :
No need to mention that this is no good practice and that we should rather use to distinct maps or a small struct for each error page. We can log this as enhancement.